[ISSUE #4403] Fix redis admin spi#4405
Merged
xwm1992 merged 5 commits intoapache:masterfrom Aug 29, 2023
Merged
Conversation
Pil0tXia
requested changes
Aug 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
============================================
- Coverage 17.82% 17.77% -0.05%
- Complexity 1514 1515 +1
============================================
Files 604 613 +9
Lines 25559 25632 +73
Branches 2400 2377 -23
============================================
+ Hits 4556 4557 +1
- Misses 20564 20636 +72
Partials 439 439
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pil0tXia
approved these changes
Aug 27, 2023
Member
Pil0tXia
left a comment
There was a problem hiding this comment.
LGTM and please create a seperate issue.
pandaapo
reviewed
Aug 29, 2023
...entmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java
Show resolved
Hide resolved
...entmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java
Show resolved
Hide resolved
Pil0tXia
requested changes
Aug 29, 2023
...entmesh-storage-redis/src/main/java/org/apache/eventmesh/storage/redis/admin/RedisAdmin.java
Show resolved
Hide resolved
qqeasonchen
approved these changes
Aug 29, 2023
xwm1992
approved these changes
Aug 29, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
* feat: fix redis admin spi. * feat: fix redis admin spi. * feat: fix redis admin spi. * feat: fix redis admin spi. * feat: fix redis admin spi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4403.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Fix the SPI extension admin-api loading of eventmesh-storage-redis
Documentation