Skip to content

[ISSUE #4087] Anonymous new can be replaced with lambda.[AsyncSubClient]#4391

Merged
mxsm merged 1 commit intoapache:masterfrom
kartiktayal:enhance-4087
Aug 23, 2023
Merged

[ISSUE #4087] Anonymous new can be replaced with lambda.[AsyncSubClient]#4391
mxsm merged 1 commit intoapache:masterfrom
kartiktayal:enhance-4087

Conversation

@kartiktayal
Copy link
Contributor

Fixes #4087

Please refer #4087 for details. Code optimisation done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@harshithasudhakar harshithasudhakar changed the title ISSUE #4087 [ISSUE #4087] Anonymous new can be replaced with lambda.[AsyncSubClient] Aug 22, 2023
Copy link
Member

@harshithasudhakar harshithasudhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4391 (292ab21) into master (3d4e922) will not change coverage.
The diff coverage is n/a.

❗ Current head 292ab21 differs from pull request most recent head 51fd5aa. Consider uploading reports for the commit 51fd5aa to get more accurate results

@@            Coverage Diff            @@
##             master    #4391   +/-   ##
=========================================
  Coverage     17.85%   17.85%           
  Complexity     1514     1514           
=========================================
  Files           602      602           
  Lines         25518    25518           
  Branches       2400     2400           
=========================================
  Hits           4555     4555           
  Misses        20524    20524           
  Partials        439      439           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit d7abc31 into apache:master Aug 23, 2023
@kartiktayal kartiktayal deleted the enhance-4087 branch August 23, 2023 14:28
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Anonymous new can be replaced with lambda.[AsyncSubClient]

4 participants