[ISSUE #4388] Improve the rocketmq source connector offset ack#4389
Merged
xwm1992 merged 2 commits intoapache:masterfrom Aug 23, 2023
Merged
[ISSUE #4388] Improve the rocketmq source connector offset ack#4389xwm1992 merged 2 commits intoapache:masterfrom
xwm1992 merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4389 +/- ##
============================================
- Coverage 17.85% 17.84% -0.01%
Complexity 1514 1514
============================================
Files 602 602
Lines 25518 25514 -4
Branches 2400 2386 -14
============================================
- Hits 4555 4552 -3
Misses 20524 20524
+ Partials 439 438 -1 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
qqeasonchen
approved these changes
Aug 22, 2023
pandaapo
reviewed
Aug 23, 2023
...n/java/org/apache/eventmesh/connector/rocketmq/source/connector/RocketMQSourceConnector.java
Show resolved
Hide resolved
pandaapo
approved these changes
Aug 23, 2023
1 task
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…pache#4389) * [ISSUE apache#4388] Improve the rocketmq source connector offset ack * update comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4388 .
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation