Fix Sankey alignment to better match thumbnail preview #147
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 21271
Background:
While reviewing the Sankey diagram alignment discussed in the issue,
I explored how vertical centering affects the visual consistency between the example page and its thumbnail preview.
Before sankey:
Full size sankey
sankey-itemstyle (18).html
centered sankey :
centered full size sankey
sankey-itemstyle (19).html
If the Sankey nodes are forced to be exactly centered in the page, it creates two problems:
=> The layout does not match the thumbnail image preview.
=> Visual consistency between the example gallery thumbnail and the opened chart view is lost.
Because of this mismatch, strict page-level centering may not provide the best user experience.
Thumbnail matches sankey:
This update keeps the Sankey alignment behavior that:
=> Matches the thumbnail preview more accurately
=> Maintains visual consistency across the examples gallery
=> Avoids unnecessary forced centering that could break expected layout appearance
Thumbnail according Sankey matches with last one images as u can clear see
For the Sankey example context, this approach provides a more practical and visually aligned result than strict page centering.