Merged
Conversation
tustvold
approved these changes
Jan 4, 2024
| # Reproducer for https://github.com/apache/arrow-datafusion/issues/8738 | ||
| # This query should work correctly | ||
| query error DataFusion error: External error: Arrow error: Invalid argument error: RowConverter column schema mismatch, expected Utf8 got Dictionary\(Int32, Utf8\) | ||
| SELECT |
Contributor
There was a problem hiding this comment.
FWIW all the quoting makes this quite hard to read, and doesn't appear to be necessary
Contributor
Author
There was a problem hiding this comment.
I agree it is not necessary, however it is what we tell our customers to do (so they don't have to deal with the upper/lower case distinction) and thus it is very common in our production systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8738
Rationale for this change
#8738 is a regression, but there was no test coverage. Thus I would like to ensure we don't introduce additional bugs while fixing it or in the future
We have also hit similar regressions in the past related to handling of dictionaries.
What changes are included in this PR?
Introduce a test that contains basic timeseries data with a schema like we use, along with several queries, including the one that errors due to #8738
Are these changes tested?
The change is all tests
Are there any user-facing changes?
No, this is test change only