Change first/last implementation to prevent redundant comparisons when data is already sorted#8678
Merged
comphead merged 3 commits intoapache:mainfrom Dec 30, 2023
synnada-ai:feature/first_last_subsequent
Merged
Change first/last implementation to prevent redundant comparisons when data is already sorted#8678comphead merged 3 commits intoapache:mainfrom synnada-ai:feature/first_last_subsequent
comphead merged 3 commits intoapache:mainfrom
synnada-ai:feature/first_last_subsequent
Conversation
ozankabak
approved these changes
Dec 29, 2023
Contributor
ozankabak
left a comment
There was a problem hiding this comment.
I reviewed this in detail and it looks good to me. With this, FIRST/LAST functions get the best of both worlds: They make no comparison at all if their inputs are already sorted, but they can work with unsorted data too!
comphead
reviewed
Dec 29, 2023
| } | ||
|
|
||
| pub fn convert_to_last(self) -> LastValue { | ||
| let name = if self.name.starts_with("FIRST") { |
Contributor
There was a problem hiding this comment.
case sensitive, or it comes upper case always?
Contributor
There was a problem hiding this comment.
AFAIK it always comes in uppercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This is a follow up PR for PR8662. With the changes in this PR, first last aggregation does not make comparisons on its data when it is known that their input data already satisfies the ordering requirement.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?