WIP Prototype new DFSchema implementation#7944
Closed
alamb wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
alamb
commented
Oct 26, 2023
| /// Inner arrow schema | ||
| inner: SchemaRef, | ||
|
|
||
| /// Optional qualifiers for each column in this schema. In the same order as |
Contributor
Author
There was a problem hiding this comment.
This is the key design --remove DFField and simply wrap an inner arrow Schema ref.
Contributor
Author
|
I think @matthewmturner is working on something real, so closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have long been bothered by the amount of copying required in DFSchema and how akward it is to use and how much duplication (e.g. metadata handling) there is between it and Schema
The current setup also makes adding additional indexes such as described on #7698 very hard
This PR is part of a plan to review the current implementation and possibly simplify it / prepare for faster DataFusion planning