Skip to content

Minor: comments that explain the schema used in simply_expressions #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Oct 10, 2023
Merged

Minor: comments that explain the schema used in simply_expressions #7747

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b2f709
Minor: comments that explain the schema used in simply_expressions
alamb Oct 5, 2023
8105225
Apply suggestions from code review
alamb Oct 5, 2023
aaaca8a
Merge remote-tracking branch 'apache/main' into alamb/simplify_expr_docs
alamb Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,16 @@ impl SimplifyExpressions {
let schema = if !plan.inputs().is_empty() {
DFSchemaRef::new(merge_schema(plan.inputs()))
} else if let LogicalPlan::TableScan(scan) = plan {
// When predicates are pushed into a table scan, there needs to be
// a schema to resolve the fields against.
// When predicates are pushed into a table scan, there is no input
// schema to resolve predicates against, so it must be handled specially
//
// Note that this is not `plan.schema()` which is the *output*
// schema, and reflects any pushed down projection. The output schema
// will not contain columns that *only* appear in pushed down predicates
// (and no where else) in the plan.
//
// Thus, use the full schema of the inner provider without any
// projection applied for simplification
Arc::new(DFSchema::try_from_qualified_schema(
&scan.table_name,
&scan.source.schema(),
Expand Down