Add documentation about type signatures, and export TIMEZONE_WILDCARD#7726
Merged
alamb merged 3 commits intoapache:mainfrom Oct 7, 2023
Merged
Add documentation about type signatures, and export TIMEZONE_WILDCARD#7726alamb merged 3 commits intoapache:mainfrom
TIMEZONE_WILDCARD#7726alamb merged 3 commits intoapache:mainfrom
Conversation
TIMEZONE_WILDCARDTIMEZONE_WILDCARD
2010YOUY01
reviewed
Oct 2, 2023
Contributor
2010YOUY01
left a comment
There was a problem hiding this comment.
Nice doc, I also found Volatility confusing when first saw it
Co-authored-by: Yongting You <2010youy01@gmail.com>
mhilton
approved these changes
Oct 3, 2023
Contributor
mhilton
left a comment
There was a problem hiding this comment.
Thanks for those documentation changes, they make things a lot clearer.
yjshen
approved these changes
Oct 6, 2023
Contributor
Author
|
Thanks @yjshen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #7720
Rationale for this change
While reviewing #7720 from @mhilton
I realized that the type coercion / signatures were not as well documented as well as they could be (e.g. the fact that DataFuson would coerce arguments for example, was somewhat implied).
What changes are included in this PR?
SignatureandTypeSignaturedocumentationTIMEZONE_PLACEHOLDERtoTIMEZONE_WILDCARD(added in fix: coerce text to timestamps with timezones #7720) to better represent what it meansAre these changes tested?
Yes, with a new doc example as well as existing tests
Are there any user-facing changes?
better docs and
TIMEZONE_WILDCARDis better documented