add error handling and boundary checking for window frames#530
Merged
alamb merged 1 commit intoapache:masterfrom Jun 10, 2021
Merged
add error handling and boundary checking for window frames#530alamb merged 1 commit intoapache:masterfrom
alamb merged 1 commit intoapache:masterfrom
Conversation
a86818f to
2f60903
Compare
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 76.03% 76.07% +0.04%
==========================================
Files 157 156 -1
Lines 26990 26923 -67
==========================================
- Hits 20521 20483 -38
+ Misses 6469 6440 -29
Continue to review full report at Codecov.
|
Member
Author
yeah window functions are hard |
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* fix issues * fix TODO * clippy * use df 33.0.0-rc1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #529
Closes #528
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?