Provide a builder for ListingOptions #4180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Nov 12, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @mvanschellebeeck -- I think it looks great!
I'll leave this PR open for a day or two so others can comment if they want
cc @tustvold
Comment on lines
+38
to
+40
| .with_table_partition_cols(vec![]) | ||
| .with_collect_stat(true) | ||
| .with_target_partitions(1); |
Contributor
There was a problem hiding this comment.
We could further simplify this code and avoid explicitly specifying the default values (last three lines)
But that can also be done as a follow on PR
| self | ||
| } | ||
|
|
||
| /// Set number of target partitions on [`ListingOptions`] and returns self. |
andygrove
approved these changes
Nov 14, 2022
Member
andygrove
left a comment
There was a problem hiding this comment.
LGTM. Thanks @mvanschellebeeck and @alamb
Contributor
|
Thanks again @mvanschellebeeck -- I took the liberty of merging up from master to resolve the conflicts (that I caused with d2814c9 / #4170) |
Contributor
|
I couldn't push directly to this PR But I put my proposed changes in |
Contributor
|
Thanks again @mvanschellebeeck -- this is so much nicer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4178
What changes are included in this PR?
Improves the ergonomics of Listing Options by providing a builder.