Add PartialOrd and Ord to GroupByScalar (#364)#368
Merged
Dandandan merged 1 commit intoapache:masterfrom May 23, 2021
Merged
Conversation
Signed-off-by: Raphael Taylor-Davies <r.taylordavies@googlemail.com>
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 75.86% 75.88% +0.01%
==========================================
Files 143 143
Lines 23758 23773 +15
==========================================
+ Hits 18025 18041 +16
+ Misses 5733 5732 -1
Continue to review full report at Codecov.
|
alamb
approved these changes
May 21, 2021
Contributor
alamb
left a comment
There was a problem hiding this comment.
makes total sense to me. 👍
Dandandan
approved these changes
May 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #364.
Rationale for this change
Allows comparing GroupByScalar values
What changes are included in this PR?
Adds PartialOrd and Ord derives to GroupByScalar
Are there any user-facing changes?
No, only changes a crate-local. There didn't seem to be consensus on the ticket as to whether I should make this enum public