Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
|
test failure caused by #3327 |
| push: | ||
| pull_request: | ||
| # manual trigger | ||
| workflow_dispatch: |
There was a problem hiding this comment.
|
Thanks @waynexia -- this looks great. |
|
I took the liberty of merging this branch to master -- hope to merge it when green |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Codecov Report
@@ Coverage Diff @@
## master #3323 +/- ##
==========================================
- Coverage 85.81% 85.81% -0.01%
==========================================
Files 294 294
Lines 53764 53764
==========================================
- Hits 46136 46135 -1
- Misses 7628 7629 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark runs are scheduled for baseline = 70e702c and contender = e0a765d. e0a765d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
Thanks ❤️ |
* MINOR: add github action trigger Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Update .github/workflows/rust.yml Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Ruihang Xia waynestxia@gmail.com
Which issue does this PR close?
Ref #3321.
Rationale for this change
GitHub Action will only run on PR updating, we cannot trigger one on demand manually. This is inconvenient if we want to run one on master or without submitting a PR.
I've tried this patch in my fork repo, now I can see this button:

What changes are included in this PR?
Add an [action trigger](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch] that allows us to trigger an action manually.
Are there any user-facing changes?
No