Merged
Conversation
30ae5df to
a4d55db
Compare
Codecov Report
@@ Coverage Diff @@
## master #2705 +/- ##
==========================================
- Coverage 84.66% 84.66% -0.01%
==========================================
Files 270 270
Lines 46919 46919
==========================================
- Hits 39726 39723 -3
- Misses 7193 7196 +3
Continue to review full report at Codecov.
|
andygrove
approved these changes
Jun 6, 2022
liukun4515
approved these changes
Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my test that sqlparser 0.18.0 is good to go -- it only required very minor changes to DataFusion -- see 30ae5dfUpdates DataFusion to use sqlparser
0.18.0-- see changelog https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md#0180-2022-06-06[0.18.0] 2022-06-06
Added
CLOSE(cursors) (refactor sort exec stream and combine batches #515) - Thanks @ovrDECLARE(cursors) (Prepare Ballista crates for publishing #509) - Thanks @ovrFETCH(cursors) (Support modulus op #510) - Thanks @ovrDATETIMEkeyword (hash_join.rs's create_hashes function panics with float columns with nightly rustc #512) - Thanks @komukomoUNNESTas a table factor (Define the unittests using pytest #493) - Thanks @sivchariCREATE FUNCTION(hive flavor) (panic! 'index out of bounds: the len is 0 but the index is 0 with bad sql query #496) - Thanks @mobuchowski$or?) inLIMITclause ([Python] Raise DataFusionError instead of plain Exceptions #494) - Thanks @step-babyIS TRUEandIS FALSE(Explain verbose should include optimized physical plan #499) - Thanks @ovrDISCARD [ALL | PLANS | SEQUENCES | TEMPORARY | TEMP]( Add support for boolean columns in pruning logic #500) - Thanks @gandronchikarray<..>HIVE data types ([Python] Support pathlib.Path arguments for ExecutionContext.register_* methods #491) - Thanks @mobuchowskiSETvalues that begin with-Add join types to Python dataframe #495 - Thanks @mobuchowskiBigQuerydialect (Support pruning forbooleancolumns #490) - Thanks @komukomoChanged:
ArrayIndex::indexstoArrayIndex::indexes(Add window frame constructs #492) - Thanks @alambFixed:
COLLATEafter parentheses in expressions (Support pruning on string columns using LIKE #507) - Thanks @razzolini-qpqFROM(Add window frame constructs - alternative #506) - Thanks @razzolini-qpqMERGE INTOsemicolon handling (add expr::like and expr::notlike to pruning logic #508) - Thanks @mskrzypkows