Implement count distinct for dictionary arrays#256
Merged
alamb merged 4 commits intoapache:masterfrom May 6, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #249
Rationale for this change
I have dictionary encoded data that I want to be able to compute distinct counts
What changes are included in this PR?
This implementation has the the basic "get it working" version. A more optimized implementation (e.g. only looking at the dictionary contents) is left for a subsequent PR and #258 tracks better performance
Are there any user-facing changes?
queries like
select count(distinct tag_col) from ...are now supported whentag_colis a dictionary encoded column