chore(deps): Update sqlparser to 0.60#19672
Conversation
|
Could we address the CI failures? Looks like some tests are failing |
Signed-off-by: StandingMan <jmtangcs@gmail.com>
0ea9df1 to
c2dd55b
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
@Jefffrey ready to review. |
|
I was literally about to sit down and have codex try to do this -- thank you @Standing-Man -- taking a look now |
alamb
left a comment
There was a problem hiding this comment.
Looks good to me @Standing-Man -- thank you. THe only question I have is about the change of API to use Boxed results
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
alamb
left a comment
There was a problem hiding this comment.
Thanks @Standing-Man and @Jefffrey
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Jefffrey
left a comment
There was a problem hiding this comment.
It is very tempting to not destructure the nested fields/enums because it makes the code less verbose. However, by doing so we miss fields that might be introduced in newer versions. These fields usually correspond to supporting more syntax. If we are unaware of this syntax, it means the SQL dialect we have will start accepting more and more syntax even if we don't do anything with the syntax.
I admit it might be painful and verbose to do it that way but I find its a very good way to use Rust's characteristics to help us catch this issues at compile time, instead of at runtime.
|
@Standing-Man could you please refrain from marking the comments as resolved? I see quite of few of my recent comments were marked as resolved even though no action was taken. Can you leave it to us to determine if a conversation is resolved, it makes it easier for us to review. |
40f8931 to
4cac0a2
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
4cac0a2 to
8f15b82
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Jefffrey
left a comment
There was a problem hiding this comment.
I'll mark this as API change because RelationPlanning is in the public API
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
|
@alamb, could you take a look when you have time? |
|
Thanks @Standing-Man & @alamb |
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?