test: add for join fuzz tests different amount of columns#18788
Closed
rluvaton wants to merge 2 commits intoapache:mainfrom
Closed
test: add for join fuzz tests different amount of columns#18788rluvaton wants to merge 2 commits intoapache:mainfrom
rluvaton wants to merge 2 commits intoapache:mainfrom
Conversation
Member
Author
|
These new tests found 9 failures:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
## Which issue does this PR close? - Closes #18804. ## Rationale for this change ## What changes are included in this PR? Take correct columns ## Are these changes tested? Yes, - added rust tests to hit invalid code paths - sqltests - fuzz tests enhancement to fuzzify columns count Fuzz tests are taken from @rluvaton 's #18788 , excluding those this PR doesn't fix: ``` fuzz_cases::join_fuzz::test_right_anti_join_1k_binary_filtered fuzz_cases::join_fuzz::test_right_anti_join_1k_filtered fuzz_cases::join_fuzz::test_right_semi_join_1k_filtered ``` ## Are there any user-facing changes?
Member
Author
|
Closed in favor of the PR that fix it |
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
## Which issue does this PR close? - Closes apache#18804. ## Rationale for this change ## What changes are included in this PR? Take correct columns ## Are these changes tested? Yes, - added rust tests to hit invalid code paths - sqltests - fuzz tests enhancement to fuzzify columns count Fuzz tests are taken from @rluvaton 's apache#18788 , excluding those this PR doesn't fix: ``` fuzz_cases::join_fuzz::test_right_anti_join_1k_binary_filtered fuzz_cases::join_fuzz::test_right_anti_join_1k_filtered fuzz_cases::join_fuzz::test_right_semi_join_1k_filtered ``` ## Are there any user-facing changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
sort_merge_joinand different number of columns between each side #18787Rationale for this change
Just adding tests to see what fails
What changes are included in this PR?
added for all fuzz tests in join to have different amount of columns in each side
Are these changes tested?
N/A
Are there any user-facing changes?
Nope