[branch-50] Backport Prevent exponential planning time for Window functions - v2 #17684 #17778
Merged
alamb merged 2 commits intoapache:branch-50from Sep 26, 2025
Merged
Conversation
…7684) * fix * Update mod.rs * Update mod.rs * Update mod.rs * tests copied from v1 pr * test case from review comment apache#17684 (comment) * one more test case * Update mod.rs * Update datafusion/physical-plan/src/windows/mod.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Update datafusion/physical-plan/src/windows/mod.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Update mod.rs * Update mod.rs --------- Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This was referenced Sep 25, 2025
Contributor
Author
|
CI Failure is due to out of disk space, which @2010YOUY01 fixed on main. I have retriggered things |
Contributor
Author
|
@2010YOUY01 or @Jefffrey -- do either if you two remember what PR fixed the "out of space on device" problems on CI? I spent a few minutes trying to find it and I couldn't despite my best github archeology skills. This PR (backporting to branch-50) is hitting it https://github.com/apache/datafusion/actions/runs/18017424338/job/51322145417?pr=17778
|
Contributor
Contributor
Author
|
Merged up to get #17795 and hopefully it will pass CI this time |
findepi
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
50.1.0(minor) #17594Rationale for this change
The fix for #17594 was requested for inclusion in DataFusion 50.1.0.
What changes are included in this PR?
branch-50branchAre these changes tested?
Yes new tests
Are there any user-facing changes?
No