Closed
Conversation
AdamGS
commented
Sep 15, 2025
| let mut reader = | ||
| ParquetMetaDataReader::new_with_metadata(m).with_page_indexes(true); | ||
| let mut reader = ParquetMetaDataReader::new_with_metadata(m) | ||
| .with_page_index_policy(PageIndexPolicy::Required); |
Contributor
Author
There was a problem hiding this comment.
This should be the exact same behavior, there's even a From<bool> for PageIndexPolicy implementation that does the same thing.
Contributor
|
I also made a PR to do this here: One thing I am still trying to figure out with @nuno-faria is the IO changes with predicate pushdown |
Contributor
|
Thank you for this PR |
Contributor
Author
|
That's my bad 🤦 should probably have looked specifically at your PRs. I'll close this one. |
Contributor
No worry -- it is actually my bad I should not have kept the other PR waiting so long. I'll polish that one up and get it reviewed and hopefully ready to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
56.1.0(August 2025) arrow-rs#7837Rationale for this change
Aside from general maintenance and performance improvements, it includes casting support for decimal 32/64, which should be merged before #17501.
What changes are included in this PR?
parquet.Are these changes tested?
Are there any user-facing changes?