fix: Ensure the CachedParquetFileReader respects the metadata prefetch hint#17302
Merged
alamb merged 1 commit intoapache:mainfrom Sep 13, 2025
Merged
fix: Ensure the CachedParquetFileReader respects the metadata prefetch hint#17302alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
Super small PR, looks like this one maybe slipped through the cracks? Probably should make it into DF 50 if possible. |
alamb
approved these changes
Sep 13, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @nuno-faria and @shehabgamin
Is there some way we can add a test for this behavior so we don't introduce a regression in the future?
Contributor
Author
I thought about adding one when creating the PR but don't know if the prefetch information is exposed to the outside. |
45 tasks
18 tasks
shehabgamin
pushed a commit
to lakehq/datafusion
that referenced
this pull request
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Uses the
metadata_size_hintwhen reading metadata in theCachedParquetFileReader, if available, so the behavior is consistent with the documentation.What changes are included in this PR?
metadata_size_hinttoCachedParquetFileReader.Are these changes tested?
N/A.
Are there any user-facing changes?
No.