feat: Avoid duplicate PhyscialExpr evaluation on hash table #16719
Closed
jonathanc-n wants to merge 4 commits intoapache:mainfrom
Closed
feat: Avoid duplicate PhyscialExpr evaluation on hash table #16719jonathanc-n wants to merge 4 commits intoapache:mainfrom
PhyscialExpr evaluation on hash table #16719jonathanc-n wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While looking into hash join spilling I noticed that the physical expression is being executed twice when creating
JoinLeftData; once when updating hash and once to return the left side data.What changes are included in this PR?
Remove the duplication. Evaluate indices once and hand it to
update_hashthen concatenate together to formJoinLeftData.Are these changes tested?
By existing tests