Add change to VARCHAR in the upgrade guide#16216
Conversation
| 1 row(s) fetched. | ||
| Elapsed 0.004 seconds. | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Thank you @alamb , i think we also need to add note:
If customers use avro format, for datafusion 48.0, we need to set datafusion.sql_parser.map_varchar_to_utf8view = false;
Because the support for utf8view for avro are not releasing currently.
There was a problem hiding this comment.
Than you @zhuqi-lucas -- good call. Hopefully by the time we release Datafusion 48 the upstream supprt for avro will be released too.
Interesting @comphead , we are currently have the option to disable it and fall back to UTF8: But it seems if we also have the VARCHAR/VARCHAR2 , it's also a improvement from customer side. Thanks! |
Thanks @comphead -- this is an interesting idea. I think if there is strong demand to make it easier to distinguish between Utf8 and Utf8View it is worth pursuing that. |
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
|
Had to merge this so we had at least one commit today 😅 |
|
Thanks @comphead and @zhuqi-lucas |
Which issue does this PR close?
VARCHARfromUtf8toUtf8View#15096VARCAHRfromUtf8toUtf8View#16142Rationale for this change
Let's add some documentation to the upgrade guide about the change in #16142
What changes are included in this PR?
Upgrade guide updates
Are these changes tested?
Are there any user-facing changes?