-
Notifications
You must be signed in to change notification settings - Fork 2k
Preserve projection for inline scan #15811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -498,7 +498,7 @@ impl LogicalPlanBuilder { | |
| TableScan::try_new(table_name, table_source, projection, filters, fetch)?; | ||
|
|
||
| // Inline TableScan | ||
| if table_scan.filters.is_empty() { | ||
| if table_scan.projection.is_none() && table_scan.filters.is_empty() { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, nice find! I'm wondering if we can still inline
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The previous implementation did what you said. |
||
| if let Some(p) = table_scan.source.get_logical_plan() { | ||
| let sub_plan = p.into_owned(); | ||
| // Ensures that the reference to the inlined table remains the | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to check the plan, so we know inline table rewrite works as expected