Update datafusion-testing pin (to fix extended test on main)#15655
Merged
alamb merged 1 commit intoapache:mainfrom Apr 9, 2025
Merged
Update datafusion-testing pin (to fix extended test on main)#15655alamb merged 1 commit intoapache:mainfrom
alamb merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
Run extended tests |
phillipleblanc
approved these changes
Apr 9, 2025
Contributor
Author
|
Thanks @phillipleblanc and @xudong963 |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
With short circuiting in expressions from @acking-you in #15462, DataFusion now successfully runs some queries that it used to fail on
@Omega359 verified that Postgres and DuckDB also successfully complete these queries:
He also updated the expected results in
What changes are included in this PR?
Update datafusion main to use the updated expected results
Are these changes tested?
I tried to run the extended suite on this PR here: https://github.com/apache/datafusion/pull/15655/checks?check_run_id=40243127451 but that doesn't seem to be working
I tested them manually locally using
INCLUDE_SQLITE=true cargo test --profile release-nonlto --test sqllogictestsResults were:
Are there any user-facing changes?