Merged
Conversation
houqp
approved these changes
Jan 14, 2022
Contributor
|
why not support |
Contributor
Author
|
liukun4515
approved these changes
Jan 14, 2022
Contributor
liukun4515
left a comment
There was a problem hiding this comment.
LGTM
you can rebase the master, after the Clippy fixed
jimexist
reviewed
Jan 16, 2022
| if let ScalarValue::Float64(Some(c)) = covar { | ||
| if let ScalarValue::Float64(Some(s1)) = stddev1 { | ||
| if let ScalarValue::Float64(Some(s2)) = stddev2 { | ||
| return Ok(ScalarValue::Float64(Some(c / s1 / s2))); |
Contributor
Author
There was a problem hiding this comment.
They may be 0, pushed a fix. Thanks for finding this.
Contributor
|
Thanks @realno ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR add the
corrfunction which is part of #1486Rationale for this change
Add correlation function to DataFusion.
What changes are included in this PR?
New function
corr(col1, co2)is added.Are there any user-facing changes?
New function
corr(col1, co2)is added.No breaking change.