Mark ARRAY_AGG(DISTINCT ...) not implemented#1534
Merged
alamb merged 1 commit intoapache:masterfrom Jan 11, 2022
Merged
Conversation
33a5b1a to
dda9b5a
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is the last change required to close #1512
Rationale for this change
Right now
array_agg(distinct ...)doesn't work. The physical plan construction logic uses the non-distinctarray_aggwhether or not distinct was specified. Interestingly enough it still works correctly under certain conditions, due to theSingleDistinctToGroupByoptimizer rule.As an example, consider the following queries:
After this change distinct array agg will throw an error when
SingleDistinctToGroupBydoes not apply.I'm planning on working on actually implementing distinct array_agg after this, but figured this was worth fixing for now.
What changes are included in this PR?
This marks the aggregation not implemented, and adds a block for testing count/approx distinct/array agg with
distinct = true.