feat: topk functionality for aggregates should support utf8view and largeutf8

[zhuqi-lucas]

Which issue does this PR close?

• Closes sub-task topk functionality for aggregates should support utf8view for

#15096

Rationale for this change

topk functionality for aggregates should support utf8view

What changes are included in this PR?

topk functionality for aggregates should support utf8view

Are these changes tested?

Yes

Are there any user-facing changes?

topk functionality for aggregates should support utf8view

[zhuqi-lucas]

I will add sqllogictesting after the config PR merged:

#15104

[alamb]

Thanks @zhuqi-lucas -- looks good to me

I'll wait for SQL test coverage before hitting approve

Any chance you are willing to add LargeUtf8` support while you are at it?

[zhuqi-lucas]

Thanks @zhuqi-lucas -- looks good to me

I'll wait for SQL test coverage before hitting approve

Any chance you are willing to add LargeUtf8` support while you are at it?

Thank you @alamb for review, i am willing to add LargeUtf8 support also!

[zhuqi-lucas]

Thanks @zhuqi-lucas -- looks good to me

I'll wait for SQL test coverage before hitting approve

Any chance you are willing to add LargeUtf8` support while you are at it?

Thank you @alamb, enabled the slt testing for utf8view and also add LargeUtf8 support in latest PR.

[alamb]

Thanks @zhuqi-lucas -- I just have one more test request

[alamb]

this change now loses coverage for utf8

Instead perhaps we can make a table with stringview?

Something like

CREATE TABLE traces_utf8view 
AS SELECT 
  arrow_cast(trace_id, 'Utf8View') as trace_id,
  timestamp,
  other
)

And then do an explain

explain select trace_id, MAX(timestamp) from traces group by trace_id order by MAX(timestamp) desc limit 4;

[alamb]

Also it would be great to do the same fir LargeUtf8

[zhuqi-lucas]

Good point, thank you @alamb.

[zhuqi-lucas]

Thanks @zhuqi-lucas -- I just have one more test request

Thank you @alamb for review, addressed it in latest PR!

[alamb]

Thank you for your patience and perseverence @zhuqi-lucas

[alamb]

FYI @avantgardnerio

[alamb]

Thanks again @zhuqi-lucas