Tests for support try_cast/cast decimal to numeric #1465
Conversation
ec34918 to
3950f7e
Compare
3950f7e to
89370f8
Compare
|
I will try and review this later today but I may not be able to review until tomorow |
alamb
left a comment
There was a problem hiding this comment.
Thanks @liukun4515 -- the only comment I have is it would be nice to reduce some of the duplication if possible, but also a bit of duplication in the tests isn't a horrible thing either.
👍
| // 3. evaluate the expression | ||
| // 4. verify that the resulting expression is of type B | ||
| // 5. verify that the resulting values are downcastable and correct | ||
| macro_rules! generic_decimal_to_other_test_cast { |
There was a problem hiding this comment.
its unfortunate that this code shares so much with generic_test_cast (seems like everything except the creation of the array). I wonder if it would be possible to refactor the validation so that it could be shared.
|
It appears this PR has some conflicts that need to be resolved now |
I have traced this as a subtask in #1443 |
|
Thanks again @liukun4515 |
Which issue does this PR close?
part of #1443
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?