Validate and unpack function arguments tersely#14513
Merged
findepi merged 9 commits intoapache:mainfrom Feb 5, 2025
Merged
Conversation
Add a `take_function_args` helper that provides convenient unpacking of function arguments along with validation that the provided argument count matches the expected. A few functions are updated to leverage the new pattern to demonstrate its usefulness.
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
this exports only the newly added take_function_args function. all other utils members are pub(crate)
mbrobbel
reviewed
Feb 5, 2025
Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com>
comphead
reviewed
Feb 5, 2025
comphead
reviewed
Feb 5, 2025
comphead
reviewed
Feb 5, 2025
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
comphead
approved these changes
Feb 5, 2025
Contributor
And we already have a taker: #14516 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
take_function_argshelper that provides convenient unpacking of function arguments along with validation that the provided argument count matches the expected. A few functions are updated to leverage the new pattern to demonstrate its usefulness.