Skip to content

Accept any uncorrelated plan when checking subquery correlation#14463

Closed
findepi wants to merge 1 commit intoapache:mainfrom
findepi:findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802
Closed

Accept any uncorrelated plan when checking subquery correlation#14463
findepi wants to merge 1 commit intoapache:mainfrom
findepi:findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802

Conversation

@findepi
Copy link
Member

@findepi findepi commented Feb 3, 2025

For the purpose of decorrelation, an uncorrelated plan is a unit. No verification needs to be performed on it.

This follows #13523 / #13498
it is believed to be a more correct solution to that issue, until we support real unnest decorrelation.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Feb 3, 2025
For the purpose of decorrelation, an uncorrelated plan is a unit. No
verification needs to be performed on it.
@findepi findepi force-pushed the findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802 branch from fd7d6f0 to d670b56 Compare February 3, 2025 21:46
@findepi findepi requested a review from alamb February 4, 2025 06:34
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi

This looks quite similar to #14474

Again, it would be great to add some test coverage to this code as well but since it has no tests now I don't think that is required for merge

@findepi
Copy link
Member Author

findepi commented Feb 5, 2025

This looks quite similar to #14474

Yes, that PR includes this as the first commit.

Will close in favor.

@findepi findepi closed this Feb 5, 2025
@findepi findepi deleted the findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802 branch February 5, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_correlations_in_subquery should not check uncorrelated plan nodes

2 participants