Improve case expr constant handling for when <scalar>#14159
Merged
jayzhan211 merged 1 commit intoapache:mainfrom Jan 20, 2025
Merged
Improve case expr constant handling for when <scalar>#14159jayzhan211 merged 1 commit intoapache:mainfrom
case expr constant handling for when <scalar>#14159jayzhan211 merged 1 commit intoapache:mainfrom
Conversation
alamb
commented
Jan 18, 2025
| } | ||
| } | ||
| } | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
This is not actually possible as the previous version of the code expands out a constant to an array
ColumnarValue::Array(when_expr_value.into_array(batch.num_rows())?)| } | ||
| // WHEN [false | null] --> NULL | ||
| ColumnarValue::Scalar(_) => { | ||
| ColumnarValue::Array(when_expr_value.into_array(batch.num_rows())?) |
Contributor
Author
There was a problem hiding this comment.
This line has the effect of creating an array out of a scalar -- I remove that and added the special case handling for the values
case expr constant handlingcase expr constant handling for when <scalar>
Contributor
|
LGTM |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #14156Which issue does this PR close?
Rationale for this change
While reviewing #14156 I noticed that the code unecessairly expanded a constant to an array, and that I could update it avoid having any internal errors
What changes are included in this PR?
Are these changes tested?
yes, with new slt tests
Are there any user-facing changes?