Skip to content

Minor: improve error message when ARRAY literals can not be planned #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 3 commits into from
Dec 21, 2024
Merged

Minor: improve error message when ARRAY literals can not be planned #13859

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
056c253
Minor: improve error message when ARRAY literals can not be planned
alamb Dec 20, 2024
457fc5f
fmt
alamb Dec 20, 2024
5bcb794
Update datafusion/sql/src/expr/value.rs
alamb Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions datafusion/sql/src/expr/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ use arrow_schema::{DataType, DECIMAL256_MAX_PRECISION};
use bigdecimal::num_bigint::BigInt;
use bigdecimal::{BigDecimal, Signed, ToPrimitive};
use datafusion_common::{
internal_datafusion_err, internal_err, not_impl_err, plan_err, DFSchema,
DataFusionError, Result, ScalarValue,
internal_datafusion_err, not_impl_err, plan_err, DFSchema, DataFusionError, Result,
ScalarValue,
};
use datafusion_expr::expr::{BinaryExpr, Placeholder};
use datafusion_expr::planner::PlannerResult;
Expand Down Expand Up @@ -169,7 +169,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
}
}

internal_err!("Expected a simplified result, but none was found")
not_impl_err!("Could not plan array literal. Hint: Please try with `nested_expressions` DataFusion feature enabled")
}

/// Convert a SQL interval expression to a DataFusion logical plan
Expand Down