Enable parquet pushdown_filter by default#12524
Closed
alamb wants to merge 4 commits intoapache:mainfrom
Closed
Conversation
Contributor
Author
|
This is a fascinating result. Som of the queries become crazy fast (the ones with selective predicates) but some become slower Query1 SELECT COUNT(*) FROM hits WHERE "AdvEngineID" <> 0;
Query 20: I need to spend some time looking at the queries that got slower in more detail TPCH also shows many queries getting slower: |
6 tasks
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft as I am:
Which issue does this PR close?
Closes #3463
Rationale for this change
Now that #4028 is completed thanks to @itsjunetime in #12135 we do not re-apply the filter twice it may be possible to enable filter pushdown for ParquetExec
in all cases and get faster performance.
What changes are included in this PR?
Are these changes tested?
Yes, functionally by CI
Are there any user-facing changes?
Performance:
(RUNNING)