Minor: Add tests for using FilterExec when parquet was pushed down#12362
Merged
alamb merged 3 commits intoapache:mainfrom Sep 7, 2024
Merged
Minor: Add tests for using FilterExec when parquet was pushed down#12362alamb merged 3 commits intoapache:mainfrom
alamb merged 3 commits intoapache:mainfrom
Conversation
alamb
commented
Sep 6, 2024
| 02)--TableScan: alltypes_plain projection=[id], partial_filters=[alltypes_plain.id > Int32(3)] | ||
| physical_plan | ||
| 01)CoalesceBatchesExec: target_batch_size=8192 | ||
| 02)--FilterExec: id@0 > 3 |
Contributor
Author
There was a problem hiding this comment.
The goal of #4028 is to remove this FilterExec
782509b to
62dfe90
Compare
62dfe90 to
bbe30e0
Compare
Jefffrey
approved these changes
Sep 6, 2024
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
Test case makes sense to me 👍
Comment on lines
+49
to
+50
| statement ok | ||
| set datafusion.execution.parquet.pushdown_filters = true; |
Contributor
There was a problem hiding this comment.
Is it worth setting this to false before creation of t explicitly, or reckon it's unnecessary and fine to rely on defaults?
Contributor
Author
There was a problem hiding this comment.
It is a good idea to make it explicit -- I will do so and add a comment about that (update in 2373f37)
Contributor
Author
|
Thanks again @Jefffrey for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4028
Rationale for this change
While reviewing #12135 from @itsjunetime I wanted to make sure everything was hooked up end to end and that the appropriate plan changes were done.
I figured I would write such tests as part of my review, though for some reason the PR doesn't actually improve these plans (I will comment on that separately).
What changes are included in this PR?
This adds "end to end" tests that show what should happen when parquet filter pushdown is enabled (specifically the FilterExec should be gone)
Are these changes tested?
yes, only tests
Are there any user-facing changes?
No, only tests