test: re-enable window function over parquet with forced collisions#11939
Merged
alamb merged 2 commits intoapache:mainfrom Aug 14, 2024
Merged
test: re-enable window function over parquet with forced collisions#11939alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
Contributor
|
I re-ran the relevant test: cargo test --test sqllogictests --features=force_hash_collisions -- parquetAnd indeed it passes locally for me too |
comphead
reviewed
Aug 13, 2024
|
|
||
| # FIXME(#TODO) fails with feature `force_hash_collisions` | ||
| # https://github.com/apache/datafusion/issues/11660 | ||
| # Perform the query: |
Contributor
There was a problem hiding this comment.
Suggested change
| # Perform the query: |
Contributor
There was a problem hiding this comment.
Would be great to add some comments why test is so specific
Contributor
There was a problem hiding this comment.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
alamb
approved these changes
Aug 14, 2024
|
|
||
| # FIXME(#TODO) fails with feature `force_hash_collisions` | ||
| # https://github.com/apache/datafusion/issues/11660 | ||
| # Perform the query: |
Contributor
There was a problem hiding this comment.
I agree better comments would be nice -- however I don't think this PR makes the comment any more/less cryptic, so I don't think we should hold it for better comments.
Maybe we can improve the comments as a future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11660.
Rationale for this change
After several attempts to reproduce the failure locally and in fork CI it still was not reproducing. Also I wasn't able to find any workflow failure related to 1.80 upgrade in PRs and on main. So, trying to just uncomment the test.
What changes are included in this PR?
Test uncommented.
Are these changes tested?
Are there any user-facing changes?