Rewrite CommonSubexprEliminate to avoid copies using TreeNode#10067
Rewrite CommonSubexprEliminate to avoid copies using TreeNode#10067alamb wants to merge 1 commit intoapache:mainfrom
CommonSubexprEliminate to avoid copies using TreeNode#10067Conversation
Sure -- that would be great @peter-toth -- I actually had a secret plan to work on the CSE rewrite tomorrow (I swear!) as I will be traveling and on a plane Just let me know what you want to do |
|
Sure, please work on it if you have some time during the weekend as I can't do it earlier than next week. |
Will do -- thank you |
|
Superceded by #10835, will continue work there |
WIP -- still has many more copies to remove
Which issue does this PR close?
Part of #9637
related to #9873
Rationale for this change
Let's make planning faster by not copying so much in the optimizer using the new TreeNode API.
What changes are included in this PR?
Note this pass still leaves a lot to be desired in terms of copying Exprs / making strings but it is much better now. Fixing up the additional copies is tracked with #9873
Are these changes tested?
Functional: existing tests
Performance: TBD
Are there any user-facing changes?