Merged
Conversation
Pull Request Test Coverage Report for Build 2840047609
💛 - Coveralls |
alamb
approved these changes
Aug 11, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
LGTM -- thanks @MazterQyou
Contributor
|
@MazterQyou -- github shows that this PR has conflicts that must be resolved (likely with #559) -- can you please resolve them (probably needs a merge from main) |
Contributor
Author
|
This PR is almost guaranteed to conflict with #563 so I'll wait for that to be merged first, then rebase. |
Contributor
|
#563 has been merged |
cc29d03 to
bb34268
Compare
Contributor
Author
|
@alamb rebased the PR branch and also extended another test in |
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 2, 2024
Can drop this after rebase on commit 18881f8 "Support SHOW COLLATION (apache#564)", first released in 0.21.0
mcheshkov
pushed a commit
to cube-js/sqlparser-rs
that referenced
this pull request
Sep 3, 2024
Can drop this after rebase on commit 18881f8 "Support SHOW COLLATION (apache#564)", first released in 0.21.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for MySQL-specific
SHOW COLLATIONstatement with full syntax support, as well as a related test.