Support Snowflake Update-From-Select#1604
Merged
alamb merged 9 commits intoapache:mainfrom Dec 24, 2024
Merged
Conversation
iffyio
reviewed
Dec 19, 2024
Contributor
Author
|
Thank you @iffyio for your feedback, I asked your opinion in one of the comments. |
Contributor
Author
|
@iffyio appreciate your feedback again 🙏 |
iffyio
reviewed
Dec 23, 2024
Contributor
iffyio
left a comment
There was a problem hiding this comment.
Left a couple comments, otherwise this looks good to me overall!
| // Reserved for Snowflake table sample | ||
| Keyword::SAMPLE, | ||
| Keyword::TABLESAMPLE, | ||
| Keyword::FROM, |
Contributor
There was a problem hiding this comment.
is this change related to the PR (wasn't clear to me if so)?
Contributor
Author
There was a problem hiding this comment.
Yes.
When removing this as a keyword the following error occurs:
Error during parsing: ParserError("Expected: ), found: t1 at Line: 9, Column: 13")
iffyio
approved these changes
Dec 24, 2024
Contributor
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @yuval-illumex!
cc @alamb
Comments Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Change parameter Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following query works in Snowflake:
UPDATE t1 FROM ( SELECT name, id FROM t1 GROUP BY id ) AS t2 SET name = t2.name WHERE t1.id = t2.idToday the parser only supports update-set-from