Fix quoted identifier regression edge-case with "from" in SELECT

[alexander-beedie]

#1212 introduced a regression in the recently released 0.48, disallowing the (valid) quoted identifier "from" in SELECT clauses, eg:

SELECT dt, rate, "to", "from" FROM fx_rates

Improved the check by additionally confirming that the potentially invalid from is not quoted, and added coverage.

---

FYI: this was caught by our (Polars) SQL unit tests while I was looking to upgrade us to 0.48 to take advantage of some recent PRs. Not sure if you usually make minor point releases to address regressions? If not, we can wait until 0.49 (or temporarily point to the fix on a branch), so no rush if that's the case 👍

[coveralls]

Pull Request Test Coverage Report for Build 9992710189

Details

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.001%) to 89.195%

---

Totals
Change from base Build 9944212602:	0.001%
Covered Lines:	26861
Relevant Lines:	30115

---

💛 - Coveralls

[alamb]

Thank you very much @alexander-beedie

cc @MohamedAbdeen21 as the author of #1212

@alexander-beedie I don't think we are setup to make a 0.48.1 patch release at this time, but I think I could make a small 0.49.0 release.

[alexander-beedie]

@alexander-beedie I don't think we are setup to make a 0.48.1 patch release at this time, but I think I could make a small 0.49.0 release.

That would be great; whatever best fits your release model is fine by me 🙂

[MohamedAbdeen21]

Nice catch. Thanks for fixing it

[alamb]

Thanks again -- I'll try and release the next version sometime this week: #1332

[alexander-beedie]

Thanks again -- I'll try and release the next version sometime this week: #1332

Fantastic; will finish integrating the new code on our side once it's out.

[alamb]

This fix has been published as part of 0.49.0 which is on crates.io: https://crates.io/crates/sqlparser/0.49.0

[alexander-beedie]

This fix has been published as part of 0.49.0 which is on crates.io: https://crates.io/crates/sqlparser/0.49.0

Many thanks!