Fix Snowflake SELECT * wildcard REPLACE ... RENAME order#1321
Merged
alamb merged 1 commit intoapache:mainfrom Jun 27, 2024
Merged
Fix Snowflake SELECT * wildcard REPLACE ... RENAME order#1321alamb merged 1 commit intoapache:mainfrom
SELECT * wildcard REPLACE ... RENAME order#1321alamb merged 1 commit intoapache:mainfrom
Conversation
7ef2d21 to
e4ceed7
Compare
Pull Request Test Coverage Report for Build 9635875595Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9635889639Details
💛 - Coveralls |
iffyio
approved these changes
Jun 26, 2024
REPLACE ... RENAME orderSELECT * wildcard REPLACE ... RENAME order
alamb
approved these changes
Jun 27, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @alexander-beedie and @iffyio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affects parsing of Snowflake
SELECT * <opts>wildcard options that contain bothRENAMEandREPLACEoptions.As per the Snowflake docs1:
Made a minor fix and added a unit test to validate it and provide the missing coverage.
Footnotes
https://docs.snowflake.com/en/sql-reference/sql/select#parameters ↩