CreateIndex: Move Display fmt to struct#1307
Merged
alamb merged 1 commit intoapache:mainfrom Jun 17, 2024
Merged
Conversation
Move the Display trait `fmt` implementation to the CreateIndex struct to to allow for display! The struct was created in a0f511c with the CreateTable `fmt` being moved, but the CreateIndex was not. Follows up from apache#1291
Pull Request Test Coverage Report for Build 9467753604Details
💛 - Coveralls |
jmhain
approved these changes
Jun 12, 2024
alamb
approved these changes
Jun 17, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
nice -- thank you @philipcristiano and @jmhain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Display trait
fmtimplementation to the CreateIndex struct to to allow for display!The struct was created in a0f511c with the CreateTable
fmtbeing moved, but the CreateIndex was not.Follows up from #1291