feat: add CatalogProviderList support #1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
nuno-faria
approved these changes
Feb 8, 2026
python/datafusion/catalog.py
Outdated
| ... | ||
|
|
||
| @abstractmethod | ||
| def catalog(self, name: str) -> Catalog | None: |
Contributor
There was a problem hiding this comment.
Shouldn't the return type here be CatalogProvider?
Member
Author
There was a problem hiding this comment.
Good point! This should be any of the 3 returnable types, including Catalog.
| ... | ||
|
|
||
| def register_catalog( # noqa: B027 | ||
| self, name: str, catalog: CatalogProviderExportable | CatalogProvider | Catalog |
Contributor
There was a problem hiding this comment.
Also is the Catalog type here correct?
Member
Author
There was a problem hiding this comment.
Yes, especially if they want to register an in-memory catalog they created with the static method.
|
|
||
| class CustomCatalogProviderList(dfn.catalog.CatalogProviderList): | ||
| def __init__(self): | ||
| self.catalogs = {"my_catalog": CustomCatalogProvider()} |
Contributor
There was a problem hiding this comment.
Maybe this could have an additional catalog just to show it supports multiple ones.
Member
Author
There was a problem hiding this comment.
I added a different catalog type in the register test to follow.
Member
Author
|
Thanks for the review @nuno-faria ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #1156
Rationale for this change
We currently support the following kinds of providers: Catalog, Schema, and Table. There is one more in the heirarchy, CatalogProviderList. This adds the missing support.
What changes are included in this PR?
Following the same patterns as in CatalogProvider (and others) this adds support for Python and Rust based CatalogProviderList. It adds the option to register a new provider list with the session context.
Are there any user-facing changes?
New addition only.