COUCHDB-2722 Keys from rewrited query params should be blank when not specified in the URI

[supertinou]

Bug Fix

COUCHDB-2722

The keys from the rewrited query params of a view should be blank when not specified in the URL.

Please see the following JIRA link for more details...

JIRA

https://issues.apache.org/jira/browse/COUCHDB-2722

Related Pull Requests

• Fix against couchdb-couch : COUCHDB-2722 Keys from rewrited query params should be blank when not specified in the URI couchdb-couch#59
• Fix against couchdb-chttpd : COUCHDB-2722 Keys from rewrited query params should be blank when not specified in the URI couchdb-chttpd#36

Thanks to @benel and @nicoolas25
cc @robertkowalski, @janl

Any comment, review is always welcome.

[robertkowalski]

@supertinou wow thank you - you are awesome!

sadly i have to admit that i have not done much with rewritten query params, so let me ping @rnewson who might be a better reviewer than me.

[supertinou]

Thank you @robertkowalski!

As we are sadly not able to see the tests running with the fix I was wondering if it would possible in one way to make a new pull request only for testing purpose in which I would keep these tests and replace the master branch of couch and chttpd by my fixed branches COUCHDB-2722
https://github.com/apache/couchdb/blob/master/rebar.config.script#L24-25

Is it possible to reference custom remote branches for the compilation of couchdb ?

NB : Maybe no need to change the chttpd branch on that testing PR as the tests are only running against the old backdoor ports which are served by apache/couchdb-couch.

Thanks again @robertkowalski

[robertkowalski]

@supertinou sorry for the late answer.

Is it possible to reference custom remote branches for the compilation of couchdb ?

yes that is possible, see https://github.com/robertkowalski/couchdb/blob/couchdb-perf-not-optimized/rebar.config.script#L25 for an example

you can also try to run the testsuite locally before submitting a PR:

make javascript should kick off the js testsuite (use make eunit for running the erlang testsuite)

https://github.com/apache/couchdb/blob/master/Makefile#L161

[robertkowalski]

@supertinou hi, what is the status on the issue? *friendly nudge *

[wohali]

Ping @supertinou . We'd love to merge this if you can run the tests and get back to us.

[benel]

@wohali Martin did this for me when he was one of my students. I'm not sure he's still on GitHub.
Which tests do you need to be run? Travis tests?

If yes, here is a rebase on CouchDB master branch:
https://travis-ci.org/benel/couchdb/builds/213346474
I will open a pull request if it's OK.

[wohali]

@benel Yes thank you! Open a new PR and reference this one. I will close this one now.