Nouveau bin script now houses most of the logic.#167
Merged
big-r81 merged 3 commits intoapache:feat/snapcraft/couchdb_and_couchdb-nouveaufrom Dec 7, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When installing snap via instances, the SNAP_INSTANCE variable is bound late. I moved most of the logic from the yaml file to the nouveau.sh file. Minor edits to the install hooks. Removed unused files and stanzas.
Testing recommendations
Works using snapcraft remote-build (after creating a faux git init). I get to the nouveau banner. I stopped testing there.