[EXEC-121] Wait for async execution until process has started#144
Draft
Marcono1234 wants to merge 1 commit intoapache:masterfrom
Draft
[EXEC-121] Wait for async execution until process has started#144Marcono1234 wants to merge 1 commit intoapache:masterfrom
Marcono1234 wants to merge 1 commit intoapache:masterfrom
Conversation
This also has the side effect of ensuring that the process destroyer, if any, is registered.
1537887 to
9859217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has the side effect of ensuring that the process destroyer, if any, is registered.
Have marked this as draft for now because I am not sure if this a good solution. It causes the following behavior differences (which might be acceptable though):
ExecuteStreamHandlerMaybe the race condition reported in EXEC-121 could also be solved differently by having another shutdown hook which verifies that all processes are started and their process destroyers (if any) have been registered. Though this logic might be quite complicated.