Ovmsupport #9
Ovmsupport #9
Conversation
|
Hey, @snuf can you rebase this against master, let's merge it on master if it works functionally and the build passes with smoke tests? |
|
Hey Rohit, It’s been rebased with master two days ago, so should be a “breeze”, is there a specific point you want me to merge with ? Cheers, Funs On 05 Dec 2014, at 18:31, Rohit Yadav [email protected] wrote:
|
|
That's great Funs. I see it's already passing smoke tests on TravisCI so we can merge it on master whenever you advise? If it's functionally working with good enough coverage and tests I would say go ahead and merge it on master right away. |
|
Hi Rohit, Well there are a couple of things here: 1st: I work on a fork and pull in upstream master and merge that into ovmsupport (https://github.com/snuf/cloudstack/tree/ovmsupport) so in principle that makes the ovmsupport tree aligned with master including my patches. Does this answer your question ? I genuinely think there should be some coverage for the integration layer into Cloudstack which is kind of absent? Cheers, Funs On 06 Dec 2014, at 14:02, Rohit Yadav [email protected] wrote:
|
|
Hi Funs, Thanks for replying. Alright let us know when you've good set of integration tests, I'm halfway with a new integration testing system semi-automated by ansible that uses CloudStack to test CloudStack. In that I run KVM, Xen etc. as VMs on KVM hosts all managed by CloudStack. Regards. |
on by default in python
The User table's UUID column is restricted to 40 chars only, since we don't know how long the nameID/userID of a SAML authenticated user will be - the fix hashes that user ID and takes a substring of length 40 chars. For hashing, SHA256 is used which returns a 64 char length string. - Fix tests, add test cases - Improve checkSAMLUser method - Use SHA256 one way hashing to create unique UUID for SAML users Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit b2b4962) Signed-off-by: Rohit Yadav <[email protected]>
As per Version 1 cookies, certain characters are now allowed such as space, colons etc but they should be url encoded using UTF8 encoding. The frontend has a cookie value unboxing method that removes any double quotes that are added. As per the doc http://download.oracle.com/javase/6/docs/api/java/net/URLEncoder.html values are application/x-www-form-urlencoded and as per http://www.w3.org/TR/html4/interact/forms.html#h-17.13.4 whitespaces are encoded as +, therefore '+' are replaced by %20 (whitespace). Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 734bd70) Signed-off-by: Rohit Yadav <[email protected]>
The fix generates X509Certificate if missing from DB and uses that for eternity. SAML SP metadata remains same since it's using the same X509 certificate and it remains same after restarts. The certificate is serialized, base64 encoded and stored in the keystore table under a specific name. For reading, it's retrieved, base64 decoded and deserialized. Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 4358714) Signed-off-by: Rohit Yadav <[email protected]>
…the detached volumes
…n.com Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 23de431) Signed-off-by: Rohit Yadav <[email protected]>
- insecure authenticators excluded in configuration - snapshot response should have zone - remove vmsnapshots when removing accounts Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 5481485) Signed-off-by: Rohit Yadav <[email protected]> Conflicts: api/src/org/apache/cloudstack/api/response/VMSnapshotResponse.java server/src/com/cloud/api/ApiResponseHelper.java server/src/com/cloud/storage/download/DownloadActiveState.java
Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit dd5fb2e) Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 814e557) Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit f70afa1) Signed-off-by: Rohit Yadav <[email protected]>
- Adds X-XSS-Protection header - Adds X-Content-Type-Options header - Fixes to use json content type defined from global settings - Uses secure cookie if enabled in global settings Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit b6b3494) Signed-off-by: Rohit Yadav <[email protected]>
Signed-off-by: Rohit Yadav <[email protected]> (cherry picked from commit 0f819f1) Signed-off-by: Rohit Yadav <[email protected]>
git merge master Merge remote-tracking branch 'cloudstack/master' into ovmsupport
|
@snuf Funs how about we merge your stuff in? |
|
Hey Rohit, Well all was fine until I did my last two merges from master after doing the 3.3.x integration of OVM, allocate vnet breaks and rolls back on the DB all of a sudden am trying to figure out where that is. So all bits work except for network provising for a VM (jeez luckily not important at all…), so vm rollout breaks. Am looking at where and why it breaks, but am pretty not impressed at the moment :\ Cheers, Funs
|
|
Kay happy to report it was a problem in my rollout script which I changed recently cough so everything is fine, it’s just that the change left out the vlan range, so that explains a lot.. So you can go ahead and merge if you want to, I’m 3 days a way from master atm (need me to do a new pull request?). Cheers, Funs
|
Pulling back up against master so we can keep following it a bit...