Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

vm: Changing VM Snapshots and Backups to their own tabs if allowed #501

Merged
yadvr merged 4 commits into from
Jul 7, 2020
Merged

vm: Changing VM Snapshots and Backups to their own tabs if allowed #501

yadvr merged 4 commits into from
Jul 7, 2020

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Jul 7, 2020

Fixes #487

yadvr
yadvr reviewed Jul 7, 2020
View reviewed changes
src/components/view/ListApiView.vue
// specific language governing permissions and limitations
// under the License.

<template>
Copy link
Member

@yadvr yadvr Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit - can we can call this something like ListResourceTab ?

@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 7, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 7, 2020

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 7, 2020

Need to find a better way to pass the router link so it can be used against several columns if needed

@blueorangutan
Copy link

blueorangutan commented Jul 7, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/501 (JID-2232)

@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 7, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 7, 2020

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 7, 2020

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/501 (JID-2233)

@davidjumani davidjumani changed the title Changing VM Snapshots and Backups to their own tabs if allowed vm: Changing VM Snapshots and Backups to their own tabs if allowed Jul 7, 2020
@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 7, 2020

@PaulAngus Good to go ?

@PaulAngus
Copy link
Member

PaulAngus commented Jul 7, 2020

@davidjumani - what should i expect to see in http://primate-qa.cloudstack.cloud:8080/client/pr/501 ??
as an admin I see every plugin possible.

@davidjumani
Copy link
Contributor Author

davidjumani commented Jul 7, 2020 •
edited
Loading

@PaulAngus that's because backup is enabled. You can try it on an environment on which it has been disabled (apache/cloudstack#4202)

@davidjumani davidjumani marked this pull request as ready for review July 7, 2020 09:18
@yadvr yadvr merged commit 47f169a into apache:master Jul 7, 2020
@yadvr yadvr added this to the 1.0-GA milestone Jul 7, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
@davidjumani @ustcweizhou
compute: Changing VM Snapshots and Backups to their own tabs if allow…
afa200a 
…ed (#501)

Fixes #487
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yadvr yadvr yadvr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0-GA

Development

Successfully merging this pull request may close these issues.

[BUG] Backup tab is shown when Backup Framework is not enabled

4 participants

@davidjumani @blueorangutan @PaulAngus @yadvr