Skip to content

Conversation

@avamingli
Copy link
Contributor

Since we have supported ORDER BY caluse and DISTINCT ON clause references are processed in target list, open it on origin query.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

 select DISTINCT ON(c1 - 1) c1, c2 from t1 where c1 > 90
   order by c1 - 1, c2 nulls first;

Could be rewritten to:

 select DISTINCT ON(mc1 - 1) mc1, mc2 from mv
   order by mc1 - 1, mc2 nulls first;

Authored-by: Zhang Mingli [email protected]

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Since we have supported ORDER BY caluse and DISTINCT ON
clause references are processed in target list, open it
on origin query.

create incremental materialized view mv as
  select c1 as mc1, c2 as mc2, c3 as mc3, c4 as mc4
  from t1 where c1 > 90;

Origin querys:

 select DISTINCT ON(c1 - 1) c1, c2 from t1 where c1 > 90
   order by c1 - 1, c2 nulls first;

Could be rewritten to:

 select DISTINCT ON(mc1 - 1) mc1, mc2 from mv
   order by mc1 - 1, mc2 nulls first;

Authored-by: Zhang Mingli [email protected]
@avamingli avamingli requested review from my-ship-it and yjhjstz May 20, 2024 05:50
@avamingli avamingli merged commit 1b0e01f into apache:main May 22, 2024
@avamingli avamingli deleted the distinct_on branch May 22, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants