[CELEBORN-2342] Fix object aliasing in LegacySkewHandlingPartitionValidator corrupting sub-range metadata#3708
Closed
xumingming wants to merge 1 commit into
Closed
Conversation
…idator corrupting sub-range metadata When an AQE-skewed partition is split into N sub-ranges, the first sub-range's CommitMetadata object was stored by reference in both subRangeToCommitMetadataMap and currentCommitMetadataForReducer. Each subsequent sibling RPC mutated that object in-place via addCommitData(), silently inflating the TreeMap entry from bytes(A) to bytes(A)+bytes(siblings). Any task retry then sent the correct bytes(A) but found the inflated value, causing a permanent CelebornIOException mismatch and job abort. Fix: store a defensive copy in subRangeToCommitMetadataMap so sibling merges into currentCommitMetadataForReducer cannot corrupt the per-range stored value.
Contributor
Author
|
@gauravkm Can you help review this PR? |
gauravkm
approved these changes
May 28, 2026
gauravkm
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Thanks for fixing!
SteNicholas
approved these changes
Jun 1, 2026
Member
|
Thanks for fix. Merged to main(v0.7.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When an AQE-skewed partition is split into N sub-ranges, the first sub-range's CommitMetadata object was stored by reference in both subRangeToCommitMetadataMap and currentCommitMetadataForReducer. Each subsequent sibling RPC mutated that object in-place via addCommitData(), silently inflating the TreeMap entry from bytes(A) to bytes(A)+bytes(siblings). Any task retry then sent the correct bytes(A) but found the inflated value, causing a permanent CelebornIOException mismatch and job abort.
Why are the changes needed?
This is a bug of E2E Integrity Check.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
Added Unit Test.