Add pb2json depth limit #3099
Merged
Add pb2json depth limit #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chenBright
reviewed
Sep 22, 2025
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Add pb2json depth limit * fix multi json test case failed * define DEEP_RECURSION_TEST_DEPTH constant * Remove duplicate root_msg and root_val param
chenBright
pushed a commit
to chenBright/brpc
that referenced
this pull request
Sep 28, 2025
* Add pb2json depth limit * fix multi json test case failed * define DEEP_RECURSION_TEST_DEPTH constant * Remove duplicate root_msg and root_val param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: NULL
Problem Summary: Add pb2json depth limit
What is changed and the side effects?
Changed: Add recursion depth limit for ProtoMessageToJson, ProtoMessageToProtoJson, JsonToProtoMessage, ProtoJsonToProtoMessage
Side effects:
Performance effects: Slightly cost more CPU in the pb2json and json2pb functions
Breaking backward compatibility: pb message or json with a depth > 100 will convert fail. User can increase the gflag json2pb_max_recursion_depth to handle larger depth.
Check List: